summaryrefslogtreecommitdiff
path: root/kernel/auditsc.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2015-06-02 17:08:29 +0200
committerPaul Moore <pmoore@redhat.com>2015-06-11 15:49:54 -0400
commit0b08c5e59441d08ab4b5e72afefd5cd98a4d83df (patch)
treead90ee6ce9a6f59f566afbbeeee02c655aef13b6 /kernel/auditsc.c
parent5c1390c9ffdaeb9f7e544cea3a1699a341cad1fb (diff)
downloadlinux-sh-0b08c5e59441d08ab4b5e72afefd5cd98a4d83df.tar.gz
audit: Fix check of return value of strnlen_user()
strnlen_user() returns 0 when it hits fault, not -1. Fix the test in audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless there's a kernel bug so it's mostly a cosmetic fix. CC: Paul Moore <pmoore@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Paul Moore <pmoore@redhat.com>
Diffstat (limited to 'kernel/auditsc.c')
-rw-r--r--kernel/auditsc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index d81424fbec3a..f6bc31e7dca9 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct audit_context *context,
* for strings that are too long, we should not have created
* any.
*/
- if (unlikely((len == -1) || len > MAX_ARG_STRLEN - 1)) {
+ if (unlikely((len == 0) || len > MAX_ARG_STRLEN - 1)) {
WARN_ON(1);
send_sig(SIGKILL, current, 0);
return -1;