summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorMiroslav Benes <mbenes@suse.cz>2016-04-28 16:34:08 +0200
committerJiri Kosina <jkosina@suse.cz>2016-04-30 00:04:08 +0200
commitf09d90864eb7cc00cadbbfd083b4eff84c167981 (patch)
tree67671556a815610742c7680e4c7a32bd25bf4740 /kernel
parent0f49fc95b86fc77b867d643e2d38bc9f28035ed4 (diff)
downloadlinux-sh-f09d90864eb7cc00cadbbfd083b4eff84c167981.tar.gz
livepatch: make object/func-walking helpers more robust
Current object-walking helper checks the presence of obj->funcs to determine the end of objs array in klp_object structure. This is somewhat fragile because one can easily forget about funcs definition during livepatch creation. In such a case the livepatch module is successfully loaded and all objects after the incorrect one are omitted. This is very confusing. Let's make the helper more robust and check also for the other external member, name. Thus the helper correctly stops on an empty item of the array. We need to have a check for obj->funcs in klp_init_object() to make it work. The same applies to a func-walking helper. As a benefit we'll check for new_func member definition during the livepatch initialization. There is no such check anywhere in the code now. [jkosina@suse.cz: fix shortlog] Signed-off-by: Miroslav Benes <mbenes@suse.cz> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Jessica Yu <jeyu@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/livepatch/core.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index d68fbf63b083..ddef649a2914 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -683,6 +683,9 @@ static void klp_free_patch(struct klp_patch *patch)
static int klp_init_func(struct klp_object *obj, struct klp_func *func)
{
+ if (!func->old_name || !func->new_func)
+ return -EINVAL;
+
INIT_LIST_HEAD(&func->stack_node);
func->state = KLP_DISABLED;