path: root/kernel/relay.c
AgeCommit message (Collapse)AuthorLines
2016-01-22wrappers for ->i_mutex accessAl Viro-2/+2
parallel to mutex_{lock,unlock,trylock,is_locked,lock_nested}, inode_foo(inode) being mutex_foo(&inode->i_mutex). Please, use those for access to ->i_mutex; over the coming cycle ->i_mutex will become rwsem, with ->lookup() done with it held only shared. Signed-off-by: Al Viro <>
2015-06-30kernel/relay.c: use kvfree() in relay_free_page_array()Pekka Enberg-4/+1
Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2015-04-15VFS: kernel/: d_inode() annotationsDavid Howells-2/+2
relayfs and tracefs are dealing with inodes of their own; those two act as filesystem drivers Signed-off-by: David Howells <> Signed-off-by: Al Viro <>
2014-04-12Merge branch 'for-linus' of ↵Linus Torvalds-3/+1
git:// Pull vfs updates from Al Viro: "The first vfs pile, with deep apologies for being very late in this window. Assorted cleanups and fixes, plus a large preparatory part of iov_iter work. There's a lot more of that, but it'll probably go into the next merge window - it *does* shape up nicely, removes a lot of boilerplate, gets rid of locking inconsistencie between aio_write and splice_write and I hope to get Kent's direct-io rewrite merged into the same queue, but some of the stuff after this point is having (mostly trivial) conflicts with the things already merged into mainline and with some I want more testing. This one passes LTP and xfstests without regressions, in addition to usual beating. BTW, readahead02 in ltp syscalls testsuite has started giving failures since "mm/readahead.c: fix readahead failure for memoryless NUMA nodes and limit readahead pages" - might be a false positive, might be a real regression..." * 'for-linus' of git:// (63 commits) missing bits of "splice: fix racy pipe->buffers uses" cifs: fix the race in cifs_writev() ceph_sync_{,direct_}write: fix an oops on ceph_osdc_new_request() failure kill generic_file_buffered_write() ocfs2_file_aio_write(): switch to generic_perform_write() ceph_aio_write(): switch to generic_perform_write() xfs_file_buffered_aio_write(): switch to generic_perform_write() export generic_perform_write(), start getting rid of generic_file_buffer_write() generic_file_direct_write(): get rid of ppos argument btrfs_file_aio_write(): get rid of ppos kill the 5th argument of generic_file_buffered_write() kill the 4th argument of __generic_file_aio_write() lustre: don't open-code kernel_recvmsg() ocfs2: don't open-code kernel_recvmsg() drbd: don't open-code kernel_recvmsg() constify blk_rq_map_user_iov() and friends lustre: switch to kernel_sendmsg() ocfs2: don't open-code kernel_sendmsg() take iov_iter stuff to mm/iov_iter.c process_vm_access: tidy up a bit ...
2014-04-12missing bits of "splice: fix racy pipe->buffers uses"Al Viro-1/+1
that commit has fixed only the parts of that mess in fs/splice.c itself; there had been more in several other ->splice_read() instances... Signed-off-by: Al Viro <>
2014-04-01pipe: kill ->map() and ->unmap()Al Viro-2/+0
all pipe_buffer_operations have the same instances of those... Signed-off-by: Al Viro <>
2014-02-19treewide: Fix typo in Documentation/DocBookMasanari Iida-1/+1
This patch fix spelling typo in Documentation/DocBook. It is because .html and .xml files are generated by make htmldocs, I have to fix a typo within the source files. Signed-off-by: Masanari Iida <> Acked-by: Randy Dunlap <> Signed-off-by: Jiri Kosina <>
2013-07-14kernel: delete __cpuinit usage from all core kernel filesPaul Gortmaker-1/+1
The __cpuinit type of throwaway sections might have made sense some time ago when RAM was more constrained, but now the savings do not offset the cost and complications. For example, the fix in commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time") is a good example of the nasty type of bugs that can be created with improper use of the various __init prefixes. After a discussion on LKML[1] it was decided that cpuinit should go the way of devinit and be phased out. Once all the users are gone, we can then finally remove the macros themselves from linux/init.h. This removes all the uses of the __cpuinit macros from C files in the core kernel directories (kernel, init, lib, mm, and include) that don't really have a specific maintainer. [1] Signed-off-by: Paul Gortmaker <>
2013-05-08Merge branch 'for-3.10/core' of git:// Torvalds-1/+1
Pull block core updates from Jens Axboe: - Major bit is Kents prep work for immutable bio vecs. - Stable candidate fix for a scheduling-while-atomic in the queue bypass operation. - Fix for the hang on exceeded rq->datalen 32-bit unsigned when merging discard bios. - Tejuns changes to convert the writeback thread pool to the generic workqueue mechanism. - Runtime PM framework, SCSI patches exists on top of these in James' tree. - A few random fixes. * 'for-3.10/core' of git:// (40 commits) relay: move remove_buf_file inside relay_close_buf partitions/efi.c: replace useless kzalloc's by kmalloc's fs/block_dev.c: fix iov_shorten() criteria in blkdev_aio_read() block: fix max discard sectors limit blkcg: fix "scheduling while atomic" in blk_queue_bypass_start Documentation: cfq-iosched: update documentation help for cfq tunables writeback: expose the bdi_wq workqueue writeback: replace custom worker pool implementation with unbound workqueue writeback: remove unused bdi_pending_list aoe: Fix unitialized var usage bio-integrity: Add explicit field for owner of bip_buf block: Add an explicit bio flag for bios that own their bvec block: Add bio_alloc_pages() block: Convert some code to bio_for_each_segment_all() block: Add bio_for_each_segment_all() bounce: Refactor __blk_queue_bounce to not use bi_io_vec raid1: use bio_copy_data() pktcdvd: Use bio_reset() in disabled code to kill bi_idx usage pktcdvd: use bio_copy_data() block: Add bio_copy_data() ...
2013-04-30relay: use macro PAGE_ALIGN instead of FIX_SIZEzhangwei(Jovi)-4/+1
Macro FIX_SIZE is same as PAGE_ALIGN at present, so use PAGE_ALIGN instead. Thanks Andrew found this. Signed-off-by: zhangwei(Jovi) <> Cc: Jens Axboe <> Cc: Al Viro <> Cc: Eric Dumazet <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2013-04-30kernel/relay.c: move FIX_SIZE macro into relay.czhangwei(Jovi)-0/+3
It's better to place FIX_SIZE macro in relay.c, instead of relay.h Signed-off-by: zhangwei(Jovi) <> Cc: Jens Axboe <> Cc: Al Viro <> Cc: Eric Dumazet <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2013-04-30kernel/relay.c: remove unused function argument actorzhangwei(Jovi)-8/+4
Currently argument `actor' is never used in the relay reading path, so remove it. Signed-off-by: zhangwei(Jovi) <> Cc: Jens Axboe <> Cc: Al Viro <> Cc: Eric Dumazet <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2013-04-30relay: move remove_buf_file inside relay_close_bufDmitry Monakhov-1/+1
Currently remove_buf_file callback is called from from kobject release method. This result in follow issue: # blktrace -d /dev/sda1 -d /dev/sda -o test blktrace_setup() dir = create_dir() rchan = relay_open(dir,...) ->create_buf_file_callback buf_file = debugfs_create_file(dir, ) Userspace will open buf_file. Later we make a decision to stop tracing blktrace_down() relay_close(rhcan) /* just decrement kobj reference */ /* since it is not zero then callback not called */ debugfs_remove(dir) /* FAIL due to non empty dir */ Later user space will close the file and file will be deleted, but directory still exist. user_space_close() ->file_release ->release_buf_file_callback ->debugfs_remove(buf_file ## TESTCASE: # blktrace -d /dev/sda1 -d /dev/sda -o test # After that blktrace infrastructure will remain broken in # an unusable state so: blktrace -d /dev/sda1 will not work. In fact this is general issue, blktrace is just one of examples. We can not reliably remove parent dir until all users close the buf_file. Solution: We don't have to wait that long. File should be deleted inside relay_close_buf(). Signed-off-by: Dmitry Monakhov <> Signed-off-by: Jens Axboe <>
2013-02-22new helper: file_inode(file)Al Viro-2/+2
Signed-off-by: Al Viro <>
2012-06-13splice: fix racy pipe->buffers usesEric Dumazet-2/+3
Dave Jones reported a kernel BUG at mm/slub.c:3474! triggered by splice_shrink_spd() called from vmsplice_to_pipe() commit 35f3d14dbbc5 (pipe: add support for shrinking and growing pipes) added capability to adjust pipe->buffers. Problem is some paths don't hold pipe mutex and assume pipe->buffers doesn't change for their duration. Fix this by adding nr_pages_max field in struct splice_pipe_desc, and use it in place of pipe->buffers where appropriate. splice_shrink_spd() loses its struct pipe_inode_info argument. Reported-by: Dave Jones <> Signed-off-by: Eric Dumazet <> Cc: Jens Axboe <> Cc: Alexander Viro <> Cc: Tom Herbert <> Cc: stable <> # 2.6.35 Tested-by: Dave Jones <> Signed-off-by: Jens Axboe <>
2012-02-10relay: prevent integer overflow in relay_open()Dan Carpenter-2/+8
"subbuf_size" and "n_subbufs" come from the user and they need to be capped to prevent an integer overflow. Signed-off-by: Dan Carpenter <> Cc: Signed-off-by: Jens Axboe <>
2012-01-03switch debugfs to umode_tAl Viro-1/+1
Signed-off-by: Al Viro <>
2011-10-31kernel: Map most files to use export.h instead of module.hPaul Gortmaker-1/+1
The changed files were only including linux/module.h for the EXPORT_SYMBOL infrastructure, and nothing else. Revector them onto the isolated export header for faster compile times. Nothing to see here but a whole lot of instances of: -#include <linux/module.h> +#include <linux/export.h> This commit is only changing the kernel dir; next targets will probably be mm, fs, the arch dirs, etc. Signed-off-by: Paul Gortmaker <>
2010-11-05Clean up relay_alloc_page_array() slightly by using vzalloc rather than ↵Jesper Juhl-11/+4
vmalloc and memset We can optimize kernel/relay.c::relay_alloc_page_array() slightly by using vzalloc. The patch makes these changes: - use vzalloc instead of vmalloc+memset. - remove redundant local variable 'array'. - declare local 'pa_size' as const. Cuts down nicely on both source and object-code size. Signed-off-by: Jesper Juhl <> Acked-by: Pekka Enberg <> Acked-by: Mathieu Desnoyers <> Signed-off-by: Linus Torvalds <>
2010-05-27kernel/: convert cpu notifier to return encapsulate errno valueAkinobu Mita-1/+1
By the previous modification, the cpu notifier can return encapsulate errno value. This converts the cpu notifiers for kernel/*.c Signed-off-by: Akinobu Mita <> Cc: Ingo Molnar <> Cc: Peter Zijlstra <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2010-05-21pipe: add support for shrinking and growing pipesJens Axboe-5/+10
This patch adds F_GETPIPE_SZ and F_SETPIPE_SZ fcntl() actions for growing and shrinking the size of a pipe and adjusts pipe.c and splice.c (and relay and network splice) usage to work with these larger (or smaller) pipes. Signed-off-by: Jens Axboe <>
2010-03-06splice: comparing unsigned int < 0Dan Carpenter-2/+3
"ret" needs to be signed or the error handling for splice_to_pipe() won't work correctly. Signed-off-by: Dan Carpenter <> Cc: Tom Zanussi <> Cc: Jens Axboe <> Cc: Lai Jiangshan <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2009-12-16const: constify remaining pipe_buf_operationsAlexey Dobriyan-1/+1
Signed-off-by: Alexey Dobriyan <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2009-09-27const: mark struct vm_struct_operationsAlexey Dobriyan-1/+1
* mark struct vm_area_struct::vm_ops as const * mark vm_ops in AGP code But leave TTM code alone, something is fishy there with global vm_ops being used. Signed-off-by: Alexey Dobriyan <> Signed-off-by: Linus Torvalds <>
2009-04-05Merge branch 'tracing-for-linus' of ↵Linus Torvalds-3/+1
git:// * 'tracing-for-linus' of git:// (413 commits) tracing, net: fix net tree and tracing tree merge interaction tracing, powerpc: fix powerpc tree and tracing tree interaction ring-buffer: do not remove reader page from list on ring buffer free function-graph: allow unregistering twice trace: make argument 'mem' of trace_seq_putmem() const tracing: add missing 'extern' keywords to trace_output.h tracing: provide trace_seq_reserve() blktrace: print out BLK_TN_MESSAGE properly blktrace: extract duplidate code blktrace: fix memory leak when freeing struct blk_io_trace blktrace: fix blk_probes_ref chaos blktrace: make classic output more classic blktrace: fix off-by-one bug blktrace: fix the original blktrace blktrace: fix a race when creating blk_tree_root in debugfs blktrace: fix timestamp in binary output tracing, Text Edit Lock: cleanup tracing: filter fix for TRACE_EVENT_FORMAT events ftrace: Using FTRACE_WARN_ON() to check "freed record" in ftrace_release() x86: kretprobe-booster interrupt emulation code fix ... Fix up trivial conflicts in arch/parisc/include/asm/ftrace.h include/linux/memory.h kernel/extable.c kernel/module.c
2009-04-02relay: fix for possible loss/corruption of produced subbufsAravind Srinivasan-3/+5
Fix possible loss/corruption of produced subbufs in relay_subbufs_consumed(). When buf->subbufs_produced wraps around after UINT_MAX and buf->subbufs_consumed is still < UINT_MAX, the condition if (buf->subbufs_consumed > buf->subbufs_produced) will be true even for certain valid values of subbufs_consumed. This may lead to loss or corruption of produced subbufs. Signed-off-by: Aravind Srinivasan <> Cc: Tom Zanussi <> Cc: Tom Zanussi <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2009-04-02Merge branch 'tracing/core-v2' into tracing-for-linusIngo Molnar-3/+1
Conflicts: include/linux/slub_def.h lib/Kconfig.debug mm/slob.c mm/slub.c
2009-02-18timers: add mod_timer_pending()Ingo Molnar-1/+1
Impact: new timer API Based on an idea from Martin Josefsson with the help of Patrick McHardy and Stephen Hemminger: introduce the mod_timer_pending() API which is a mod_timer() offspring that is an invariant on already removed timers. (regular mod_timer() re-activates non-pending timers.) This is useful for the networking code in that it can allow unserialized mod_timer_pending() timer-forwarding calls, but a single del_timer*() will stop the timer from being reactivated again. Also while at it: - optimize the regular mod_timer() path some more, the timer-stat and a debug check was needlessly duplicated in __mod_timer(). - make the exports come straight after the function, as most other exports in timer.c already did. - eliminate __mod_timer() as an external API, change the users to mod_timer(). The regular mod_timer() code path is not impacted significantly, due to inlining optimizations and due to the simplifications. Based-on-patch-from: Stephen Hemminger <> Acked-by: Stephen Hemminger <> Cc: "David S. Miller" <> Cc: Patrick McHardy <> Cc: Cc: Oleg Nesterov <> Cc: Andrew Morton <> Signed-off-by: Ingo Molnar <>
2009-02-03Merge branches 'tracing/ftrace', 'tracing/kmemtrace' and 'linus' into ↵Ingo Molnar-1/+3
2009-01-18relay: fix lock imbalance in relay_late_setup_filesJiri Slaby-1/+3
One fail path in relay_late_setup_files() omits mutex_unlock(&relay_channels_mutex); Add it. Signed-off-by: Jiri Slaby <> Signed-off-by: Ingo Molnar <>
2008-12-30relayfs: replace BUG() with WARN_ON() in relay_late_setup_files()Ingo Molnar-3/+1
Impact: turn boot crash into boot warning This BUG() can trigger: [ 16.684131] initcall fail_page_alloc_debugfs+0x0/0xc1 returned 0 after 0 usecs [ 16.692035] calling kmemtrace_setup_late+0x0/0xd5 @ 1 [ 16.700087] relay_late_setup_files: CPU 1 has no buffer, it must have! [ 16.704044] ------------[ cut here ]------------ [ 16.708030] kernel BUG at kernel/relay.c:680! [ 16.708030] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC [ 16.708030] last sysfs file: [ 16.708030] [ 16.708030] Pid: 1, comm: swapper Not tainted (2.6.28-tip-03903-g9a39f58-dirty #13207) System Product Name [ 16.708030] EIP: 0060:[<c01604ae>] EFLAGS: 00010246 CPU: 1 [ 16.708030] EIP is at relay_late_setup_files+0x8c/0x176 Reduce it to a more reportable WARN_ONCE(). Signed-off-by: Ingo Molnar <>
2008-12-10relayfs: fix infinite loop with splice()Tom Zanussi-5/+2
Running kmemtraced, which uses splice() on relayfs, causes a hard lock on x86-64 SMP. As described by Tom Zanussi: It looks like you hit the same problem as described here: commit 8191ecd1d14c6914c660dfa007154860a7908857 splice: fix infinite loop in generic_file_splice_read() relay uses the same loop but it never got noticed or fixed. Cc: Mathieu Desnoyers <> Tested-by: Pekka Enberg <> Signed-off-by: Tom Zanussi <> Signed-off-by: Pekka Enberg <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2008-11-18relay: fix cpu offline problemLai Jiangshan-5/+4
relay_open() will close allocated buffers when failed. but if cpu offlined, some buffer will not be closed. this patch fixed it. and did cleanup for relay_reset() too. Signed-off-by: Lai Jiangshan <> Signed-off-by: Jens Axboe <>
2008-08-05relay: fix "full buffer with exactly full last subbuffer" accounting problemTom Zanussi-1/+11
In relay's current read implementation, if the buffer is completely full but hasn't triggered the buffer-full condition (i.e. the last write didn't cross the subbuffer boundary) and the last subbuffer is exactly full, the subbuffer accounting code erroneously finds nothing available. This patch fixes the problem. Signed-off-by: Tom Zanussi <> Cc: Eduard - Gabriel Munteanu <> Cc: Pekka Enberg <> Cc: Jens Axboe <> Cc: Mathieu Desnoyers <> Cc: Andrea Righi <> Cc: <> [2.6.25.x, 2.6.26.x] Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2008-07-26relay: add buffer-only channels; useful for early loggingEduard - Gabriel Munteanu-29/+141
Allows one to create and use a channel with no associated files. Files can be initialized later. This is useful in scenarios such as logging in early code, before VFS is up. Therefore, such channels can be created and used as soon as kmem_cache_init() completed. This is needed by kmemtrace to do tracing in early kernel code. [ build fix] Signed-off-by: Eduard - Gabriel Munteanu <> Cc: Tom Zanussi <> Signed-off-by: KOSAKI Motohiro <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2008-05-28splice: fix sendfile() issue with relayTom Zanussi-1/+1
Splice isn't always incrementing the ppos correctly, which broke relay splice. Signed-off-by: Tom Zanussi <> Tested-by: Dan Williams <> Signed-off-by: Jens Axboe <>
2008-05-08Revert "relay: fix splice problem"Jens Axboe-1/+1
This reverts commit c3270e577c18b3d0e984c3371493205a4807db9d.
2008-04-29Merge branch 'for-linus' of git:// Torvalds-1/+1
* 'for-linus' of git:// block: Skip I/O merges when disabled block: add large command support block: replace sizeof(rq->cmd) with BLK_MAX_CDB ide: use blk_rq_init() to initialize the request block: use blk_rq_init() to initialize the request block: rename and export rq_init() block: no need to initialize rq->cmd with blk_get_request block: no need to initialize rq->cmd in prepare_flush_fn hook block/blk-barrier.c:blk_ordered_cur_seq() mustn't be inline block/elevator.c:elv_rq_merge_ok() mustn't be inline block: make queue flags non-atomic block: add dma alignment and padding support to blk_rq_map_kern unexport blk_max_pfn ps3disk: Remove superfluous cast block: make rq_init() do a full memset() relay: fix splice problem
2008-04-29relayfs: support larger relay bufferMasami Hiramatsu-3/+32
Use vmalloc() and memset() instead of kcalloc() to allocate a page* array when the array size is bigger than one page. This enables relayfs to support bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system. [ cleanup] Signed-off-by: Masami Hiramatsu <> Cc: David Wilder <> Reviewed-by: Tom Zanussi <> Reviewed-by: Pekka Enberg <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2008-04-29relay: fix splice problemTom Zanussi-1/+1
Splice isn't always incrementing the ppos correctly, which broke relay splice. Signed-off-by: Tom Zanussi <> Signed-off-by: Jens Axboe <>
2008-03-26relay: set an spd_release() hook for spliceJens Axboe-0/+5
relay doesn't reference the pages it adds, however we need a non-NULL hook or splice_to_pipe() can oops. Signed-off-by: Jens Axboe <>
2008-03-26set relay file can not be read by pread(2)Lai Jiangshan-1/+1
I found that relay files can be read by pread(2). I fix it, for relay files are not capable of seeking. Signed-off-by: Lai Jiangshan <> Signed-off-by: Jens Axboe <>
2008-03-17relay: fix subbuf_splice_actor() adding too many pagesJens Axboe-2/+3
If subbuf_pages was larger than the max number of pages the pipe buffer will hold, subbuf_splice_actor() would happily go beyond the array size. Signed-off-by: Jens Axboe <>
2008-02-06relay: nopageNick Piggin-15/+9
Convert relay from nopage to fault. Remove redundant vma range checks. Switch from OOM to SIGBUS if the resource is not available. Signed-off-by: Nick Piggin <> Cc: Tom Zanussi <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2008-02-04vm audit: add VM_DONTEXPAND to mmap for drivers that need itNick Piggin-0/+1
Drivers that register a ->fault handler, but do not range-check the offset argument, must set VM_DONTEXPAND in the vm_flags in order to prevent an expanding mremap from overflowing the resource. I've audited the tree and attempted to fix these problems (usually by adding VM_DONTEXPAND where it is not obvious). Signed-off-by: Nick Piggin <> Signed-off-by: Linus Torvalds <>
2007-10-18whitespace fixes: relayfsDaniel Walker-3/+3
Signed-off-by: Daniel Walker <> Cc: Tom Zanussi <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2007-07-31Fix a use after free bug in kernel->userspace relay file supportJesper Juhl-1/+2
Coverity spotted what looks like a real possible case of using a variable after it has been freed. The problem is in kernel/relay.c::relay_open_buf() If the code hits "goto free_buf;" it ends up in this code : free_buf: relay_destroy_buf(buf); <--- calls kfree() on 'buf'. free_name: kfree(tmpname); end: return buf; <-- use after free of 'buf'. I read through the callers and they all handle a NULL return from this function as an error (and hitting the 'free_buf' label only happens on failure to chan->cb->create_buf_file(), so that looks like a clear error to me). The patch simply sets 'buf' to NULL after the call to relay_destroy_buf(buf); - as far as I can see that should take care of the problem. The patch also corrects a reference to a documentation file while I was at it. Note from Mathieu: the documentation reference change should have been done in a separate patch, but I guess no one will really care. Signed-off-by: Jesper Juhl <> Acked-by: "David J. Wilder" <> Tested-by: "David J. Wilder" <> Signed-off-by: Mathieu Desnoyers <> Cc: Tom Zanussi <> Cc: Karim Yaghmour <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2007-07-19kernel/relay.c: make functions staticAdrian Bunk-7/+6
Signed-off-by: Adrian Bunk <> Cc: Tom Zanussi <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
2007-07-13relay: fixup kerneldoc commentTom Zanussi-1/+1
Change comment from kerneldoc to normal. Signed-off-by: Tom Zanussi <> Signed-off-by: Jens Axboe <>
2007-07-13relay: fix bogus cast in subbuf_splice_actor()Tom Zanussi-1/+3
The current code that sets the read position in subbuf_splice_actor may give erroneous results if the buffer size isn't a power of 2. This patch fixes the problem. Signed-off-by: Tom Zanussi <> Signed-off-by: Jens Axboe <>