summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2014-10-30 20:08:40 -0400
committerRich Felker <dalias@aerifal.cx>2014-10-30 20:11:04 -0400
commit2da3ab1382ca8e39eb1e4428103764a81fba73d3 (patch)
tree366d0775bb4976aad0dd6110a2d71c576290785a /src
parent9d836ea7a69a6441fcdca815328d274e4ed6b707 (diff)
downloadmusl-2da3ab1382ca8e39eb1e4428103764a81fba73d3.tar.gz
fix invalid access by openat to possibly-missing variadic mode argument
the mode argument is only required to be present when the O_CREAT or O_TMPFILE flag is used.
Diffstat (limited to 'src')
-rw-r--r--src/fcntl/openat.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/fcntl/openat.c b/src/fcntl/openat.c
index 634c4bf3..4faeb296 100644
--- a/src/fcntl/openat.c
+++ b/src/fcntl/openat.c
@@ -6,10 +6,14 @@
int openat(int fd, const char *filename, int flags, ...)
{
mode_t mode;
- va_list ap;
- va_start(ap, flags);
- mode = va_arg(ap, mode_t);
- va_end(ap);
+
+ if ((flags & O_CREAT) || (flags & O_TMPFILE) == O_TMPFILE) {
+ va_list ap;
+ va_start(ap, flags);
+ mode = va_arg(ap, mode_t);
+ va_end(ap);
+ }
+
return syscall_cp(SYS_openat, fd, filename, flags|O_LARGEFILE, mode);
}