From c221d3e5862e249b03aa7569d5fec6389294fb22 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 6 Sep 2018 11:15:15 -0400 Subject: fix issues from public functions defined without declaration visible policy is that all public functions which have a public declaration should be defined in a context where that public declaration is visible, to avoid preventable type mismatches. an audit performed using GCC's -Wmissing-declarations turned up the violations corrected here. in some cases the public header had not been included; in others, a feature test macro needed to make the declaration visible had been omitted. in the case of gethostent and getnetent, the omission seems to have been intentional, as a hack to admit a single stub definition for both functions. this kind of hack is no longer acceptable; it's UB and would not fly with LTO or advanced toolchains. the hack is undone to make exposure of the declarations possible. --- src/legacy/utmpx.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/legacy') diff --git a/src/legacy/utmpx.c b/src/legacy/utmpx.c index e2843c94..fa69f387 100644 --- a/src/legacy/utmpx.c +++ b/src/legacy/utmpx.c @@ -1,3 +1,4 @@ +#define _GNU_SOURCE #include #include #include -- cgit v1.2.1