summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-18 21:03:13 +0100
committerDavid S. Miller <davem@davemloft.net>2014-11-19 15:27:40 -0500
commitfcd4d35ecc1636c8ac50e3a6266a620eb8ff0626 (patch)
treee0567c4658db21364382ea3e1990a4ec5f223fb8
parentef87c5d6a11af45c31910728e46642e77aa8db61 (diff)
downloadlinux-sh-fcd4d35ecc1636c8ac50e3a6266a620eb8ff0626.tar.gz
netlink: Deletion of an unnecessary check before the function call "__module_get"
The __module_get() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/netlink/af_netlink.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index d479b32d5826..e1aad6eeac14 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -142,8 +142,7 @@ int netlink_add_tap(struct netlink_tap *nt)
list_add_rcu(&nt->list, &netlink_tap_all);
spin_unlock(&netlink_tap_lock);
- if (nt->module)
- __module_get(nt->module);
+ __module_get(nt->module);
return 0;
}