summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkbuild test robot <fengguang.wu@intel.com>2016-03-27 02:54:23 +0800
committerMike Marshall <hubcap@omnibond.com>2016-04-08 14:08:38 -0400
commit2fa37fd71396b8eff72d23cafc8c583dd8eb928c (patch)
tree82f9f3a11c7c3847c6113ebb12efb0984e568f61
parenta9bb3ba81fba1750139654360cb716ab093103b0 (diff)
downloadlinux-sh-2fa37fd71396b8eff72d23cafc8c583dd8eb928c.tar.gz
Orangefs: fix ifnullfree.cocci warnings
fs/orangefs/orangefs-debugfs.c:130:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Mike Marshall <hubcap@omnibond.com>
-rw-r--r--fs/orangefs/orangefs-debugfs.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
index 19670b8b4053..1714a737d556 100644
--- a/fs/orangefs/orangefs-debugfs.c
+++ b/fs/orangefs/orangefs-debugfs.c
@@ -126,8 +126,7 @@ out:
void orangefs_debugfs_cleanup(void)
{
- if (debug_dir)
- debugfs_remove_recursive(debug_dir);
+ debugfs_remove_recursive(debug_dir);
}
/* open ORANGEFS_KMOD_DEBUG_HELP_FILE */