diff options
authorAndrey Ryabinin <>2016-11-10 10:46:38 -0800
committerLinus Torvalds <>2016-11-11 08:12:37 -0800
commit70d78fe7c8b640b5acfad56ad341985b3810998a (patch)
parent60da81ea61201f43387793d1cc3f501609d922ed (diff)
coredump: fix unfreezable coredumping task
It could be not possible to freeze coredumping task when it waits for 'core_state->startup' completion, because threads are frozen in get_signal() before they got a chance to complete 'core_state->startup'. Inability to freeze a task during suspend will cause suspend to fail. Also CRIU uses cgroup freezer during dump operation. So with an unfreezable task the CRIU dump will fail because it waits for a transition from 'FREEZING' to 'FROZEN' state which will never happen. Use freezer_do_not_count() to tell freezer to ignore coredumping task while it waits for core_state->startup completion. Link: Signed-off-by: Andrey Ryabinin <> Acked-by: Pavel Machek <> Acked-by: Oleg Nesterov <> Cc: Alexander Viro <> Cc: Tejun Heo <> Cc: "Rafael J. Wysocki" <> Cc: Michal Hocko <> Cc: <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/coredump.c b/fs/coredump.c
index 281b768000e6..eb9c92c9b20f 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1,6 +1,7 @@
#include <linux/slab.h>
#include <linux/file.h>
#include <linux/fdtable.h>
+#include <linux/freezer.h>
#include <linux/mm.h>
#include <linux/stat.h>
#include <linux/fcntl.h>
@@ -423,7 +424,9 @@ static int coredump_wait(int exit_code, struct core_state *core_state)
if (core_waiters > 0) {
struct core_thread *ptr;
+ freezer_do_not_count();
+ freezer_count();
* Wait for all the threads to become inactive, so that
* all the thread context (extended register state, like