path: root/arch/arm/kernel/kgdb.c
diff options
authorDouglas Anderson <>2018-12-04 19:38:25 -0800
committerDaniel Thompson <>2018-12-30 08:24:21 +0000
commit9ef7fa507d6b53a96de4da3298c5f01bde603c0a (patch)
treea6cbedd8fa312d94ce8d8fcb96a19e5bf4fe981d /arch/arm/kernel/kgdb.c
parent2595646791c319cadfdbf271563aac97d0843dc7 (diff)
kgdb: Remove irq flags from roundup
The function kgdb_roundup_cpus() was passed a parameter that was documented as: > the flags that will be used when restoring the interrupts. There is > local_irq_save() call before kgdb_roundup_cpus(). Nobody used those flags. Anyone who wanted to temporarily turn on interrupts just did local_irq_enable() and local_irq_disable() without looking at them. So we can definitely remove the flags. Signed-off-by: Douglas Anderson <> Cc: Vineet Gupta <> Cc: Russell King <> Cc: Catalin Marinas <> Cc: Will Deacon <> Cc: Richard Kuo <> Cc: Ralf Baechle <> Cc: Paul Burton <> Cc: James Hogan <> Cc: Benjamin Herrenschmidt <> Cc: Paul Mackerras <> Cc: Michael Ellerman <> Cc: Yoshinori Sato <> Cc: Rich Felker <> Cc: "David S. Miller" <> Cc: Thomas Gleixner <> Cc: Ingo Molnar <> Cc: Borislav Petkov <> Cc: "H. Peter Anvin" <> Acked-by: Will Deacon <> Signed-off-by: Daniel Thompson <>
Diffstat (limited to 'arch/arm/kernel/kgdb.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c
index caa0dbe3dc61..f21077b077be 100644
--- a/arch/arm/kernel/kgdb.c
+++ b/arch/arm/kernel/kgdb.c
@@ -175,7 +175,7 @@ static void kgdb_call_nmi_hook(void *ignored)
kgdb_nmicallback(raw_smp_processor_id(), get_irq_regs());
-void kgdb_roundup_cpus(unsigned long flags)
+void kgdb_roundup_cpus(void)
smp_call_function(kgdb_call_nmi_hook, NULL, 0);