path: root/arch/s390/crypto/prng.c
diff options
authorColin Ian King <>2016-09-06 09:01:31 +0200
committerMartin Schwidefsky <>2016-09-06 11:00:00 +0200
commit6512391a30f6b158488e941214541e84473b6bf9 (patch)
treee9b559bdd5c9ef52136334c54f38c6c45e7d51d7 /arch/s390/crypto/prng.c
parente68f1d4ca99e08652066f40d7778b6007f0149d9 (diff)
s390/crypto: avoid returning garbage value
Static analysis with cppcheck detected that ret is not initialized and hence garbage is potentially being returned in the case where prng_data->ppnows.reseed_counter <= prng_reseed_limit. Thanks to Martin Schwidefsky for spotting a mistake in my original fix. Fixes: 0177db01adf26cf9 ("s390/crypto: simplify return code handling") Signed-off-by: Colin Ian King <> Signed-off-by: Martin Schwidefsky <>
Diffstat (limited to 'arch/s390/crypto/prng.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index 79e3a1f6313a..9cc050f9536c 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -434,7 +434,7 @@ static int prng_sha512_generate(u8 *buf, size_t nbytes)
memcpy(prng_data->prev, buf, nbytes);
- return ret;
+ return nbytes;