path: root/drivers/firmware/google/vpd.c
diff options
authorAnton Vasilyev <>2018-07-24 18:10:38 +0300
committerGreg Kroah-Hartman <>2018-08-02 10:34:12 +0200
commit45ca3f76de0507ecf143f770570af2942f263812 (patch)
tree67c46e293ee4ae084edbf390f7bede3e21bc2b94 /drivers/firmware/google/vpd.c
parent9a481bdc16294414fa4d666ab4f4019224d880a5 (diff)
firmware: vpd: Fix section enabled flag on vpd_section_destroy
static struct ro_vpd and rw_vpd are initialized by vpd_sections_init() in vpd_probe() based on header's ro and rw sizes. In vpd_remove() vpd_section_destroy() performs deinitialization based on enabled flag, which is set to true by vpd_sections_init(). This leads to call of vpd_section_destroy() on already destroyed section for probe-release-probe-release sequence if first probe performs ro_vpd initialization and second probe does not initialize it. The patch adds changing enabled flag on vpd_section_destroy and adds cleanup on the error path of vpd_sections_init. Found by Linux Driver Verification project ( Signed-off-by: Anton Vasilyev <> Reviewed-by: Guenter Roeck <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'drivers/firmware/google/vpd.c')
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index e9db895916c3..1aa67bb5d8c0 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -246,6 +246,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr);
+ sec->enabled = false;
return 0;
@@ -279,8 +280,10 @@ static int vpd_sections_init(phys_addr_t physaddr)
ret = vpd_section_init("rw", &rw_vpd,
physaddr + sizeof(struct vpd_cbmem) +
header.ro_size, header.rw_size);
- if (ret)
+ if (ret) {
+ vpd_section_destroy(&ro_vpd);
return ret;
+ }
return 0;