path: root/drivers
diff options
authorGuillaume Nault <>2020-05-14 12:15:39 +0200
committerDavid S. Miller <>2020-05-14 13:02:50 -0700
commitb8c158395119be62294da73646a3953c29ac974b (patch)
treeada9e79715c07e93c9ce28549f7fa76eb31b2dea /drivers
parentfd4a5177382230d39e0d95632d98103fb2938383 (diff)
pppoe: only process PADT targeted at local interfaces
We don't want to disconnect a session because of a stray PADT arriving while the interface is in promiscuous mode. Furthermore, multicast and broadcast packets make no sense here, so only PACKET_HOST is accepted. Reported-by: David BalaĹžic <> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Guillaume Nault <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'drivers')
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index d760a36db28c..beedaad08255 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -490,6 +490,9 @@ static int pppoe_disc_rcv(struct sk_buff *skb, struct net_device *dev,
if (!skb)
goto out;
+ if (skb->pkt_type != PACKET_HOST)
+ goto abort;
if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
goto abort;