path: root/kernel/up.c
diff options
authorFrederic Weisbecker <>2014-02-24 16:40:02 +0100
committerJens Axboe <>2014-02-24 14:47:15 -0800
commitc46fff2a3b29794b35d717b5680a27f31a6a6bc0 (patch)
tree753afca11aeb7dd9b4f70b02a4905f5687e26af3 /kernel/up.c
parentfce8ad1568c57e7f334018dec4fa1744c926c135 (diff)
smp: Rename __smp_call_function_single() to smp_call_function_single_async()
The name __smp_call_function_single() doesn't tell much about the properties of this function, especially when compared to smp_call_function_single(). The comments above the implementation are also misleading. The main point of this function is actually not to be able to embed the csd in an object. This is actually a requirement that result from the purpose of this function which is to raise an IPI asynchronously. As such it can be called with interrupts disabled. And this feature comes at the cost of the caller who then needs to serialize the IPIs on this csd. Lets rename the function and enhance the comments so that they reflect these properties. Suggested-by: Christoph Hellwig <> Cc: Andrew Morton <> Cc: Christoph Hellwig <> Cc: Ingo Molnar <> Cc: Jan Kara <> Cc: Jens Axboe <> Signed-off-by: Frederic Weisbecker <> Signed-off-by: Jens Axboe <>
Diffstat (limited to 'kernel/up.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/up.c b/kernel/up.c
index 4e199d4cef8e..1760bf3d1463 100644
--- a/kernel/up.c
+++ b/kernel/up.c
@@ -22,7 +22,7 @@ int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
-int __smp_call_function_single(int cpu, struct call_single_data *csd)
+int smp_call_function_single_async(int cpu, struct call_single_data *csd)
unsigned long flags;
@@ -31,7 +31,7 @@ int __smp_call_function_single(int cpu, struct call_single_data *csd)
return 0;
int on_each_cpu(smp_call_func_t func, void *info, int wait)