path: root/lib
diff options
authorJohn McCutchan <>2005-08-26 14:02:04 -0400
committerLinus Torvalds <>2005-08-26 11:32:57 -0700
commit7c657f2f25d50c602df9291bc6242b98fc090759 (patch)
tree5e1ae11c320ea00488b33224cc982d0be2d986d6 /lib
parent755528c860b05fcecda1c88a2bdaffcb50760a7f (diff)
[PATCH] Document idr_get_new_above() semantics, update inotify
There is an off by one problem with idr_get_new_above. The comment and function name suggest that it will return an id > starting_id, but it actually returned an id >= starting_id, and kernel callers other than inotify treated it as such. The patch below fixes the comment, and fixes inotifys usage. The function name still doesn't match the behaviour, but it never did. Signed-off-by: John McCutchan <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'lib')
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/idr.c b/lib/idr.c
index c5be889de449..6415d053e2bf 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -207,7 +207,7 @@ build_up:
- * idr_get_new_above - allocate new idr entry above a start id
+ * idr_get_new_above - allocate new idr entry above or equal to a start id
* @idp: idr handle
* @ptr: pointer you want associated with the ide
* @start_id: id to start search at