path: root/net/core
diff options
authorFlorian Fainelli <>2014-09-02 11:17:07 -0700
committerDavid S. Miller <>2014-09-04 23:13:58 -0700
commit4a804c01635a43ed073893532c058fbaa1f5154e (patch)
tree6a76d65ac4a4227df062f376173b31f2cdff3abf /net/core
parenta9fe8e29945d56f35235a3a0fba99b4cf181d211 (diff)
net: systemport: update UMAC_CMD only when link is detected
When we bring the interface down, phy_stop() will schedule the PHY state machine to call our link adjustment callback. By the time we do so, we may have clock gated off the SYSTEMPORT hardware block, and this will cause bus errors to happen in bcm_sysport_adj_link(): Make sure that we only touch the UMAC_CMD register when there is an actual link. This is safe to do for two reasons: - updating the Ethernet MAC registers only make sense when a physical link is present - the PHY library state machine first set phydev->link = 0 before invoking phydev->adjust_link in the PHY_HALTED case This is a similar fix to the GENET one: c677ba8b3c47650358572091ed8a6af50bfca877 ("net: bcmgenet: update UMAC_CMD only when link is detected"). Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") Signed-off-by: Florian Fainelli <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions