path: root/net/ipv4/icmp.c
diff options
authorIlia Sotnikov <>2006-03-25 01:38:55 -0800
committerDavid S. Miller <>2006-03-25 01:38:55 -0800
commitcef2685e0053945ea0f3c02297386b040f486ea7 (patch)
tree869c11f64c5e2259342c228c80e93cbbbf8e4fc1 /net/ipv4/icmp.c
parentb8059eadf9f4dc24bd72da71daa832a9a9899fb4 (diff)
[IPV4]: Aggregate route entries with different TOS values
When we get an ICMP need-to-frag message, the original TOS value in the ICMP payload cannot be used as a key to look up the routes to update. This is because the TOS field may have been modified by routers on the way. Similarly, ip_rt_redirect should also ignore the TOS as the router that gave us the message may have modified the TOS value. The patch achieves this objective by aggregating entries with different TOS values (but are otherwise identical) into the same bucket. This makes it easy to update them at the same time when an ICMP message is received. In future we should use a twin-hashing scheme where teh aggregation occurs at the entry level. That is, the TOS goes back into the hash for normal lookups while ICMP lookups will end up with a node that gives us a list that contains all other route entries that differ only by TOS. Signed-off-by: Ilia Sotnikov <> Signed-off-by: Herbert Xu <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net/ipv4/icmp.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index e7bbff4340bb..9831fd2c73a0 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -753,7 +753,7 @@ static void icmp_redirect(struct sk_buff *skb)
ip_rt_redirect(skb->nh.iph->saddr, ip, skb->h.icmph->un.gateway,
- iph->saddr, iph->tos, skb->dev);
+ iph->saddr, skb->dev);