path: root/net
diff options
authorJouni Malinen <>2016-03-01 00:29:00 +0200
committerJohannes Berg <>2016-03-01 15:45:04 +0100
commit1ec7bae8bec9b72e347e01330c745ab5cdd66f0e (patch)
tree41d6b7733340af4a7c7da87ca17f131abede732c /net
parent9acc54beb474c81148e2946603d141cf8716b19f (diff)
mac80211: Fix Public Action frame RX in AP mode
Public Action frames use special rules for how the BSSID field (Address 3) is set. A wildcard BSSID is used in cases where the transmitter and recipient are not members of the same BSS. As such, we need to accept Public Action frames with wildcard BSSID. Commit db8e17324553 ("mac80211: ignore frames between TDLS peers when operating as AP") added a rule that drops Action frames to TDLS-peers based on an Action frame having different DA (Address 1) and BSSID (Address 3) values. This is not correct since it misses the possibility of BSSID being a wildcard BSSID in which case the Address 1 would not necessarily match. Fix this by allowing mac80211 to accept wildcard BSSID in an Action frame when in AP mode. Fixes: db8e17324553 ("mac80211: ignore frames between TDLS peers when operating as AP") Cc: Signed-off-by: Jouni Malinen <> Signed-off-by: Johannes Berg <>
Diffstat (limited to 'net')
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index bf2c3f281dcd..60d093f40f1d 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -3384,6 +3384,7 @@ static bool ieee80211_accept_frame(struct ieee80211_rx_data *rx)
return false;
/* ignore action frames to TDLS-peers */
if (ieee80211_is_action(hdr->frame_control) &&
+ !is_broadcast_ether_addr(bssid) &&
!ether_addr_equal(bssid, hdr->addr1))
return false;