path: root/net
diff options
authorDmitry V. Levin <>2016-02-19 04:27:48 +0300
committerDavid S. Miller <>2016-02-19 23:49:23 -0500
commitb5f0549231ffb025337be5a625b0ff9f52b016f0 (patch)
tree03efe8e30d488d9ef17671c578b2fcc07a96ffde /net
parent5a0e2f2622eb65b59bcefb01c5c475af4fab0e6d (diff)
unix_diag: fix incorrect sign extension in unix_lookup_by_ino
The value passed by unix_diag_get_exact to unix_lookup_by_ino has type __u32, but unix_lookup_by_ino's argument ino has type int, which is not a problem yet. However, when ino is compared with sock_i_ino return value of type unsigned long, ino is sign extended to signed long, and this results to incorrect comparison on 64-bit architectures for inode numbers greater than INT_MAX. This bug was found by strace test suite. Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core") Signed-off-by: Dmitry V. Levin <> Acked-by: Cong Wang <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net')
1 files changed, 1 insertions, 1 deletions
diff --git a/net/unix/diag.c b/net/unix/diag.c
index c512f64d5287..4d9679701a6d 100644
--- a/net/unix/diag.c
+++ b/net/unix/diag.c
@@ -220,7 +220,7 @@ done:
return skb->len;
-static struct sock *unix_lookup_by_ino(int ino)
+static struct sock *unix_lookup_by_ino(unsigned int ino)
int i;
struct sock *sk;