path: root/virt/kvm/async_pf.c
diff options
authorChristoffer Dall <>2017-05-17 13:12:51 +0200
committerChristoffer Dall <>2017-05-18 11:18:12 +0200
commit552c9f47f8d451830a6b47151c6d2db77f77cc3e (patch)
treeaba7044c61067224495363592c8b54a32c457fe7 /virt/kvm/async_pf.c
parent0c428a6a9256fcd66817e12db32a50b405ed2e5c (diff)
KVM: arm/arm64: Fix bug when registering redist iodevs
If userspace creates the VCPUs after initializing the VGIC, then we end up in a situation where we trigger a bug in kvm_vcpu_get_idx(), because it is called prior to adding the VCPU into the vcpus array on the VM. There is no tight coupling between the VCPU index and the area of the redistributor region used for the VCPU, so we can simply ensure that all creations of redistributors are serialized per VM, and increment an offset when we successfully add a redistributor. The vgic_register_redist_iodev() function can be called from two paths: vgic_redister_all_redist_iodev() which is called via the kvm_vgic_addr() device attribute handler. This patch already holds the kvm->lock mutex. The other path is via kvm_vgic_vcpu_init, which is called through a longer chain from kvm_vm_ioctl_create_vcpu(), which releases the kvm->lock mutex just before calling kvm_arch_vcpu_create(), so we can simply take this mutex again later for our purposes. Fixes: ab6f468c10 ("KVM: arm/arm64: Register iodevs when setting redist base and creating VCPUs") Signed-off-by: Christoffer Dall <> Tested-by: Jean-Philippe Brucker <> Reviewed-by: Eric Auger <>
Diffstat (limited to 'virt/kvm/async_pf.c')
0 files changed, 0 insertions, 0 deletions