path: root/arch/microblaze/syscall_arch.h
diff options
authorRich Felker <>2019-05-05 10:52:41 -0400
committerRich Felker <>2019-05-05 10:52:41 -0400
commit28198ac3afd33fb9017ad1283eb794e3a77832f9 (patch)
tree8e54213cd9994b8ddfad11afc402771e5c0319c5 /arch/microblaze/syscall_arch.h
parent2df8b1d806c3e1fd4b6b10e13794855a93fe6628 (diff)
fix passing of 64-bit syscall arguments on microblaze
this has been wrong since the beginning of the microblaze port: the syscall ABI for microblaze does not align 64-bit arguments on even register boundaries. commit 788d5e24ca19c6291cebd8d1ad5b5ed6abf42665 exposed the problem by introducing references to a nonexistent __syscall7. the ABI is not documented well anywhere, but I was able to confirm against both strace source and glibc source that microblaze is not using the alignment. per the syscall(2) man page, posix_fadvise, ftruncate, pread, pwrite, readahead, sync_file_range, and truncate were all affected and either did not work at all, or only worked by chance, e.g. when the affected argument slots were all zero.
Diffstat (limited to 'arch/microblaze/syscall_arch.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/microblaze/syscall_arch.h b/arch/microblaze/syscall_arch.h
index 942aaa2d..169013f8 100644
--- a/arch/microblaze/syscall_arch.h
+++ b/arch/microblaze/syscall_arch.h
@@ -1,7 +1,7 @@
#define __SYSCALL_LL_E(x) \
((union { long long ll; long l[2]; }){ .ll = x }).l[0], \
((union { long long ll; long l[2]; }){ .ll = x }).l[1]
-#define __SYSCALL_LL_O(x) 0, __SYSCALL_LL_E((x))
+#define __SYSCALL_LL_O(x) __SYSCALL_LL_E((x))
static __inline long __syscall0(long n)