diff options
author | Rich Felker <dalias@aerifal.cx> | 2011-06-14 01:35:51 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2011-06-14 01:35:51 -0400 |
commit | 7779dbd2663269b465951189b4f43e70839bc073 (patch) | |
tree | fa131e2ddcf164bf4d58a07f627a4704a0b13f73 /src/internal/pthread_impl.h | |
parent | f58c8a0f391987a65e055ae591ec59b9df7b7f7c (diff) | |
download | musl-7779dbd2663269b465951189b4f43e70839bc073.tar.gz |
fix race condition in pthread_kill
if thread id was reused by the kernel between the time pthread_kill
read it from the userspace pthread_t object and the time of the tgkill
syscall, a signal could be sent to the wrong thread. the tgkill
syscall was supposed to prevent this race (versus the old tkill
syscall) but it can't; it can only help in the case where the tid is
reused in a different process, but not when the tid is reused in the
same process.
the only solution i can see is an extra lock to prevent threads from
exiting while another thread is trying to pthread_kill them. it should
be very very cheap in the non-contended case.
Diffstat (limited to 'src/internal/pthread_impl.h')
-rw-r--r-- | src/internal/pthread_impl.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/internal/pthread_impl.h b/src/internal/pthread_impl.h index 12f8ccfc..2089c857 100644 --- a/src/internal/pthread_impl.h +++ b/src/internal/pthread_impl.h @@ -46,6 +46,7 @@ struct pthread { int unblock_cancel; int delete_timer; locale_t locale; + int killlock; }; struct __timer { |