diff options
| author | Rich Felker <dalias@aerifal.cx> | 2018-09-06 11:15:15 -0400 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2018-09-12 14:34:20 -0400 |
| commit | c221d3e5862e249b03aa7569d5fec6389294fb22 (patch) | |
| tree | 227098b1eefa6036f39a05941632771db54cf2b6 /src/stdio | |
| parent | eeb6f7742506b08692f745c7f588d046f1aa8214 (diff) | |
| download | musl-c221d3e5862e249b03aa7569d5fec6389294fb22.tar.gz | |
fix issues from public functions defined without declaration visible
policy is that all public functions which have a public declaration
should be defined in a context where that public declaration is
visible, to avoid preventable type mismatches.
an audit performed using GCC's -Wmissing-declarations turned up the
violations corrected here. in some cases the public header had not
been included; in others, a feature test macro needed to make the
declaration visible had been omitted.
in the case of gethostent and getnetent, the omission seems to have
been intentional, as a hack to admit a single stub definition for both
functions. this kind of hack is no longer acceptable; it's UB and
would not fly with LTO or advanced toolchains. the hack is undone to
make exposure of the declarations possible.
Diffstat (limited to 'src/stdio')
| -rw-r--r-- | src/stdio/ext2.c | 1 | ||||
| -rw-r--r-- | src/stdio/fwide.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/stdio/ext2.c b/src/stdio/ext2.c index f359be9a..afd8b34e 100644 --- a/src/stdio/ext2.c +++ b/src/stdio/ext2.c @@ -1,4 +1,5 @@ #include "stdio_impl.h" +#include <stdio_ext.h> size_t __freadahead(FILE *f) { diff --git a/src/stdio/fwide.c b/src/stdio/fwide.c index 8410b153..8bab634a 100644 --- a/src/stdio/fwide.c +++ b/src/stdio/fwide.c @@ -1,3 +1,4 @@ +#include <wchar.h> #include "stdio_impl.h" #include "locale_impl.h" |