summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorLines
2018-09-12reduce spurious inclusion of libc.hRich Felker-177/+43
libc.h was intended to be a header for access to global libc state and related interfaces, but ended up included all over the place because it was the way to get the weak_alias macro. most of the inclusions removed here are places where weak_alias was needed. a few were recently introduced for hidden. some go all the way back to when libc.h defined CANCELPT_BEGIN and _END, and all (wrongly implemented) cancellation points had to include it. remaining spurious users are mostly callers of the LOCK/UNLOCK macros and files that use the LFS64 macro to define the awful *64 aliases. in a few places, new inclusion of libc.h is added because several internal headers no longer implicitly include libc.h. declarations for __lockfile and __unlockfile are moved from libc.h to stdio_impl.h so that the latter does not need libc.h. putting them in libc.h made no sense at all, since the macros in stdio_impl.h are needed to use them correctly anyway.
2018-09-12use wrapper headers to hide most namespaced/internally-public symbolsRich Felker-60/+64
not all prefixed symbols can be made hidden. some are part of ABI-compat (e.g. __nl_langinfo_l) and others are ABI as a consequence of the way copy relocations for weak aliases work in ELF shared libraries. most, however, can be made hidden. with this commit, there should be no remaining unintentionally visible symbols exported from libc.so.
2018-09-12remove __vfork aliasRich Felker-28/+7
this was added so that posix_spawn and possibly other functionality could be implemented in terms of vfork, but that turned out to be unsafe. any such usage needs __clone with proper handling of stack lifetime.
2018-09-12hide purely dependency-triggering functions in stdio __toread & __towriteRich Felker-2/+2
2018-09-12declare __env_rm_add in wrapper stdlib.hRich Felker-0/+1
this is perhaps not the ideal place, but no better alternatives stand out.
2018-09-12hide dependency-triggering pointer object in malloc_usable_size.cRich Felker-2/+2
2018-09-12rework malloc_usable_size to use malloc_impl.hRich Felker-9/+1
2018-09-12remove unused __futex function and source fileRich Felker-9/+0
the direct syscall or various thin and mostly-inline wrappers around it are used instead internally. at some point a public futex function should be added, but it's not yet clear what the signature should be, and in the mean time this file is not useful.
2018-09-12hide __pthread_once_full symbolRich Felker-1/+1
this is a special case that does not need a declaration, because it's not even a libc-internal interface between translation units. instead it's a poor hack around compilers' inability to shrink-wrap critical code paths. after vis.h was disabled, it became more of a pessimization on many archs due to the extra layer of machinery to support a call through the PLT, but now it should be efficient again.
2018-09-12declare and make hidden additional internal init/exit symbolsRich Felker-0/+4
2018-09-12declare and make hidden additional internal stdio symbolsRich Felker-0/+5
2018-09-12move declaration and apply hidden visibility to __utc stringRich Felker-4/+1
2018-09-12declare and make hidden more internal locale functionsRich Felker-0/+2
2018-09-12remove unused __getdents, rename and move fileRich Felker-4/+1
the __-prefixed filename does not make sense when the only purpose of this file is implementing a public function that's not used as a backend for implementing the standard dirent functions.
2018-09-12remove or make static various unused __-prefixed symbolsRich Felker-17/+10
2018-09-12move additional pthread internal declarations to pthread_impl.h, hideRich Felker-2/+15
these were overlooked for various reasons in earlier stages.
2018-09-12apply hidden visibility to various remaining internal interfacesRich Felker-46/+52
2018-09-12apply hidden visibility to sigreturn code fragmentsRich Felker-9/+49
these were overlooked in the declarations overhaul work because they are not properly declared, and the current framework even allows their declared types to vary by arch. at some point this should be cleaned up, but I'm not sure what the right way would be.
2018-09-12apply hidden visibility to pthread internalsRich Felker-11/+11
2018-09-12apply hidden visibility to stdio internalsRich Felker-26/+26
2018-09-12apply hidden visibility to internal time[zone] implementation functionsRich Felker-8/+8
2018-09-12apply hidden visibility to internal math functionsRich Felker-26/+26
this makes significant differences to codegen on archs with an expensive PLT-calling ABI; on i386 and gcc 7.3 for example, the sin and sinf functions no longer touch call-saved registers or the stack except for pushing outgoing arguments. performance is likely improved too, but no measurements were taken.
2018-09-12overhaul internally-public declarations using wrapper headersRich Felker-192/+200
commits leading up to this one have moved the vast majority of libc-internal interface declarations to appropriate internal headers, allowing them to be type-checked and setting the stage to limit their visibility. the ones that have not yet been moved are mostly namespace-protected aliases for standard/public interfaces, which exist to facilitate implementing plain C functions in terms of POSIX functionality, or C or POSIX functionality in terms of extensions that are not standardized. some don't quite fit this description, but are "internally public" interfacs between subsystems of libc. rather than create a number of newly-named headers to declare these functions, and having to add explicit include directives for them to every source file where they're needed, I have introduced a method of wrapping the corresponding public headers. parallel to the public headers in $(srcdir)/include, we now have wrappers in $(srcdir)/src/include that come earlier in the include path order. they include the public header they're wrapping, then add declarations for namespace-protected versions of the same interfaces and any "internally public" interfaces for the subsystem they correspond to. along these lines, the wrapper for features.h is now responsible for the definition of the hidden, weak, and weak_alias macros. this means source files will no longer need to include any special headers to access these features. over time, it is my expectation that the scope of what is "internally public" will expand, reducing the number of source files which need to include *_impl.h and related headers down to those which are actually implementing the corresponding subsystems, not just using them.
2018-09-12declare __getopt_msg in stdio_impl.hRich Felker-2/+3
it's not ideal, but the function is essentially an extended stdio function specialized to getopt's needs. the only reason it exists is avoiding pulling printf code into every program using getopt.
2018-09-12use lighter internal stdio lock in getopt error printingRich Felker-2/+3
the public flockfile interface is significantly heavier because it has to handle the possibility of caller returning or thread exiting while holding the lock.
2018-09-12add crypt_des header for declarations shared with encrypt functionRich Felker-12/+16
2018-09-12make mkostemps source file include the header for its declarationRich Felker-0/+1
2018-09-12move __memalign declaration to malloc_impl.hRich Felker-4/+4
the malloc-implementation-private header is the only right place for this, because, being in the reserved namespace, __memalign is not interposable and thus not valid to use anywhere else. anything outside of the malloc implementation must call an appropriate-namespace public function (aligned_alloc or posix_memalign).
2018-09-12use hidden visibility for sh __unmapself backendsRich Felker-2/+3
2018-09-12rework mechanism for posix_spawnp calling posix_spawnRich Felker-20/+12
previously, a common __posix_spawnx backend was used that accepted an additional argument for the execve variant to call in the child. this moderately bloated up the posix_spawn function, shuffling arguments between stack and/or registers to call a 7-argument function from a 6-argument one. instead, tuck the exec function pointer in an unused part of the (large) pthread_spawnattr_t structure, and have posix_spawnp duplicate the attributes and fill in a pointer to __execvpe. the net code size change is minimal, but the weight is shifted to the "heavier" function which already pulls in more dependencies. as a bonus, we get rid of an external symbol (__posix_spawnx) that had no really good place for a declaration because it shouldn't have existed to begin with.
2018-09-12make arch __fesetround backends hiddenRich Felker-4/+18
these are not public interfaces and do not match the public function, but delegate argument checking to it.
2018-09-12make arch __set_thread_area backends hiddenRich Felker-1/+10
this is not a public interface, and does not even necessarily match the syscall on all archs that have a syscall by that name. on archs where it's implemented in C, no action on the source file is needed; the hidden declaration in pthread_arch.h suffices.
2018-09-12make arch __clone backends hiddenRich Felker-1/+16
these are not a public interface and are not intended to be callable from anywhere but the public clone function or other places in libc.
2018-09-12move tlsdesc and internal dl function declarations to dynlink.hRich Felker-20/+17
2018-09-12add internal header for declaring __pleval function (used by gettext)Rich Felker-1/+8
locale_impl.h could have been used, but this function is completely independent of anything else, and preserving that property seems nice.
2018-09-12move __stdio_exit_needed to stdio_impl.hRich Felker-4/+2
this functions is glue for linking dependency logic.
2018-09-12move __loc_is_allocated declaration to locale_impl.hRich Felker-2/+1
2018-09-12move declarations of tls setup/access functions to pthread_impl.hRich Felker-10/+6
it's already included in all places where these are needed, and aside from __tls_get_addr, they're all implementation internals.
2018-09-12add and use internal header for *rand48 lcgRich Felker-13/+12
2018-09-12move __strftime_fmt_1 declaration to time_impl.hRich Felker-2/+2
this is a helper function from strftime that's also used by wcsftime.
2018-09-12move __tm_to_tzname declaration to time_impl.h with related functionsRich Felker-1/+1
this function was added later for strftime use and the existence of time_impl.h as the appropriate place for it seems to have been overlooked.
2018-09-12remove unused code from strcpy.cRich Felker-7/+0
2018-09-12move __res_msend_rc declaration to lookup.hRich Felker-1/+1
unlike the other res/dn functions, this one is tied to struct resolvconf which is not a public interface, so put it in the private header for its subsystem.
2018-09-12fix type-mismatched declarations of __nl_langinfo_l in source filesRich Felker-2/+2
obviously the type "should be" const, but it inherited non-const from the standard nl_langinfo_l.
2018-09-12for c11 mtx and cnd functions, use externally consistent type namesRich Felker-12/+17
despite looking like undefined behavior, the affected code is correct both before and after this patch. the pairs mtx_t and pthread_mutex_t, and cnd_t and pthread_cond_t, are not mutually compatible within a single translation unit (because they are distinct untagged aggregate instances), but they are compatible with an object of either type from another translation unit (6.2.7 ΒΆ1), and therefore a given translation unit can choose which one it wants to use. in the interest of being able to move declarations out of source files to headers that facilitate checking, use the pthread type names in declaring the namespace-safe versions of the pthread functions and cast the argument pointer types when calling them.
2018-09-12move and deduplicate declarations of __dns_parse to make it checkableRich Felker-2/+3
the source file for this function is completely standalone, but it doesn't seem worth adding a header just for it, so declare it in lookup.h for now.
2018-09-12move lgamma-related internal declarations to libm.hRich Felker-12/+7
2018-09-12declare __syscall_ret as hidden in vfork asmRich Felker-0/+4
without this, it's plausible that assembler or linker could complain about an unsatisfiable relocation.
2018-09-12add arm asm for vforkPatrick Oppenlander-0/+13
2018-09-12move declarations for malloc internals to malloc_impl.hRich Felker-7/+7