From 7c41047285a24a97e700b4fb5b6b69f4505e2d82 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Tue, 11 Apr 2023 09:06:27 -0400 Subject: fix inadvertently static local var in dynlink get_lfs64 commit 246f1c811448f37a44b41cd8df8d0ef9736d95f4 inadvertently introduced the local variable p as static by declaring it together with lfs64_list. the function is only reachable under lock, and is not called reentrantly, so this is not a functional bug, but it is confusing and inefficient. fix by separating the declarations. --- ldso/dynlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ldso') diff --git a/ldso/dynlink.c b/ldso/dynlink.c index fde5f346..ceca3c98 100644 --- a/ldso/dynlink.c +++ b/ldso/dynlink.c @@ -345,7 +345,8 @@ static struct symdef find_sym(struct dso *dso, const char *s, int need_def) static struct symdef get_lfs64(const char *name) { - static const char *p, lfs64_list[] = + const char *p; + static const char lfs64_list[] = "aio_cancel\0aio_error\0aio_fsync\0aio_read\0aio_return\0" "aio_suspend\0aio_write\0alphasort\0creat\0fallocate\0" "fgetpos\0fopen\0freopen\0fseeko\0fsetpos\0fstat\0" -- cgit v1.2.1