From f4d9bfb3a986f2c25ec023426b4fb222130af75f Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Thu, 5 Sep 2013 16:57:46 +0000 Subject: math: fix atanh (overflow and underflow issues) in atanh exception handling was left to the called log functions, but the argument to those functions could underflow or overflow. use double_t and float_t to avoid some useless stores on x86 --- src/math/atanhl.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'src/math/atanhl.c') diff --git a/src/math/atanhl.c b/src/math/atanhl.c index 72a1e345..f63d60b1 100644 --- a/src/math/atanhl.c +++ b/src/math/atanhl.c @@ -17,11 +17,18 @@ long double atanhl(long double x) u.i.se = e; x = u.f; - if (e < 0x3fff - 1) { - /* |x| < 0.5, up to 1.7ulp error */ - x = 0.5*log1pl(2*x + 2*x*x/(1-x)); + if (e < 0x3ff - 1) { + if (e < 0x3ff - LDBL_MANT_DIG/2) { + /* handle underflow */ + if (e == 0) + FORCE_EVAL((float)x); + } else { + /* |x| < 0.5, up to 1.7ulp error */ + x = 0.5*log1pl(2*x + 2*x*x/(1-x)); + } } else { - x = 0.5*log1pl(2*x/(1-x)); + /* avoid overflow */ + x = 0.5*log1pl(2*(x/(1-x))); } return s ? -x : x; } -- cgit v1.2.1