From c221d3e5862e249b03aa7569d5fec6389294fb22 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Thu, 6 Sep 2018 11:15:15 -0400 Subject: fix issues from public functions defined without declaration visible policy is that all public functions which have a public declaration should be defined in a context where that public declaration is visible, to avoid preventable type mismatches. an audit performed using GCC's -Wmissing-declarations turned up the violations corrected here. in some cases the public header had not been included; in others, a feature test macro needed to make the declaration visible had been omitted. in the case of gethostent and getnetent, the omission seems to have been intentional, as a hack to admit a single stub definition for both functions. this kind of hack is no longer acceptable; it's UB and would not fly with LTO or advanced toolchains. the hack is undone to make exposure of the declarations possible. --- src/stdio/ext2.c | 1 + src/stdio/fwide.c | 1 + 2 files changed, 2 insertions(+) (limited to 'src/stdio') diff --git a/src/stdio/ext2.c b/src/stdio/ext2.c index f359be9a..afd8b34e 100644 --- a/src/stdio/ext2.c +++ b/src/stdio/ext2.c @@ -1,4 +1,5 @@ #include "stdio_impl.h" +#include size_t __freadahead(FILE *f) { diff --git a/src/stdio/fwide.c b/src/stdio/fwide.c index 8410b153..8bab634a 100644 --- a/src/stdio/fwide.c +++ b/src/stdio/fwide.c @@ -1,3 +1,4 @@ +#include #include "stdio_impl.h" #include "locale_impl.h" -- cgit v1.2.1