From a3b98a11a9b51801109ad46df2a44ee2ee03e37e Mon Sep 17 00:00:00 2001 From: Michael Forney Date: Mon, 4 Nov 2013 23:34:20 -0800 Subject: putgrent: Stop writing output on first failure This way, if an fprintf fails, we get an incomplete group entry rather than a corrupted one. --- src/passwd/putgrent.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/passwd/putgrent.c b/src/passwd/putgrent.c index d7847b15..b34f3254 100644 --- a/src/passwd/putgrent.c +++ b/src/passwd/putgrent.c @@ -6,9 +6,10 @@ int putgrent(const struct group *gr, FILE *f) int r; size_t i; flockfile(f); - r = fprintf(f, "%s:%s:%d:", gr->gr_name, gr->gr_passwd, gr->gr_gid); + if ((r = fprintf(f, "%s:%s:%d:", gr->gr_name, gr->gr_passwd, gr->gr_gid))<0) goto done; if (gr->gr_mem) for (i=0; gr->gr_mem[i]; i++) - if (fprintf(f, "%s%s", i?",":"", gr->gr_mem[i])<0) r = -1; + if ((r = fprintf(f, "%s%s", i?",":"", gr->gr_mem[i]))<0) goto done; +done: funlockfile(f); return r<0 ? -1 : 0; } -- cgit v1.2.1