diff options
author | Alexey Izbyshev <izbyshev@ispras.ru> | 2023-03-06 20:56:25 +0300 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2023-04-11 09:21:41 -0400 |
commit | 9b12982d52c5bc5b0158c07dfdbd5485f3a773a0 (patch) | |
tree | 6bca4c4824b93867e8a5290ab82fdff8076345f7 /compat/time32/clock_settime32.c | |
parent | 6d322159c633050a405b03b927db76b89e402014 (diff) | |
download | musl-9b12982d52c5bc5b0158c07dfdbd5485f3a773a0.tar.gz |
semtimedop: fix timespec kernel ABI mismatch for 32-bit timeouts on x32
For time64 support, musl normally defines SYS_foo to the time32 variant
of that syscall on arches that have it, and to the time64 variant
otherwise, so that "SYS_foo == SYS_foo_time64" implies that the arch is
time64-only. However, SYS_semtimedop is an odd case: some arches define
only SYS_semtimedop_time64, yet they are not time64-only, because the
time32 variant is provided via SYS_ipc instead. For such arches,
defining SYS_semtimedop to SYS_semtimedop_time64 would break the
implication above, so commit 4bbd7baea7c8538b3fb8e30f7b022a1eee071450
doesn't do this. Commit eb2e298cdc814493a6ced8c05cf0d0f5cccc8b63
attempts to detect time64-only arches by checking that both
SYS_semtimedop and SYS_ipc are undefined, but this doesn't work for
x32, because it's a time64-only arch that does define SYS_semtimedop.
As a result, 32-bit timeouts trigger the fallback path that passes
a 32-bit timespec to the kernel while it expects a 64-bit one, so
the effective tv_sec is formed by interpreting 32-bit tv_sec and
tv_nsec as a single long long, and the effective tv_nsec is whatever
is located in the next 64 bits of the stack.
Fix this by expanding the time64-only check to include arches where
SYS_semtimedop is the time64 variant of the syscall.
Diffstat (limited to 'compat/time32/clock_settime32.c')
0 files changed, 0 insertions, 0 deletions